Implement SsaBuilder without the ResolvedVisitor.

Implement SsaBuilder without the ResolvedVisitor.

BUG=
R=sigurdm@google.com

Committed: https://github.com/dart-lang/sdk/commit/02d52374d495d2c92d3af9f6648ef6de4ee76d43

[Johnni Winther, 2015-06-25 16:43:14]

johnniwinther@google.com changed reviewers:
+ sigurdm@google.com

[sigurdm, 2015-06-26 07:44:19]

LGTM

https://codereview.chromium.org/1212433002/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/1212433002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder.dart:3146: void visitThisGet(ast.Identifier
node, [_]) {
Should this be called `handleThisGet`? I am not exactly sure when visit- and
when handle- is used.

https://codereview.chromium.org/1212433002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder.dart:4594: visitSuperSetterInvoke(
void return type?

https://codereview.chromium.org/1212433002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder.dart:8024: visitConstantGet(
void return type?

https://codereview.chromium.org/1212433002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder.dart:8032: visitConstantInvoke(
void return type?

https://codereview.chromium.org/1212433002/diff/20001/pkg/compiler/lib/src/wa...
File pkg/compiler/lib/src/warnings.dart (right):

https://codereview.chromium.org/1212433002/diff/20001/pkg/compiler/lib/src/wa...
pkg/compiler/lib/src/warnings.dart:647: "A deferred class cannot be used to
create a "
Thanks!

[Johnni Winther, 2015-06-26 10:15:25]

https://codereview.chromium.org/1212433002/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/1212433002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder.dart:3146: void visitThisGet(ast.Identifier
node, [_]) {
On 2015/06/26 07:44:19, sigurdm wrote:
> Should this be called `handleThisGet`? I am not exactly sure when visit- and
> when handle- is used.

It is part of the [SemanticSendVisitor]. `this` is currently not a [Send] (just
an identifier) but should be.

'handle' is used for helper methods that group visits together, from instance
from [BaseImplementationsOfCompoundsMixin].

https://codereview.chromium.org/1212433002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder.dart:4594: visitSuperSetterInvoke(
On 2015/06/26 07:44:19, sigurdm wrote:
> void return type?

Done.

https://codereview.chromium.org/1212433002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder.dart:8024: visitConstantGet(
On 2015/06/26 07:44:19, sigurdm wrote:
> void return type?

Done.

https://codereview.chromium.org/1212433002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder.dart:8032: visitConstantInvoke(
On 2015/06/26 07:44:19, sigurdm wrote:
> void return type?

Done.

[Johnni Winther, 2015-06-26 10:48:34]

Committed patchset #3 (id:40001) manually as
02d52374d495d2c92d3af9f6648ef6de4ee76d43 (presubmit successful).