Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1212313005: Continuously update the compact reporter's clock. (Closed)

Created:
5 years, 5 months ago by nweiz
Modified:
5 years, 5 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Continuously update the compact reporter's clock. Previously, the clock was only updated when a line was going to be printed anyway, but that made it appear to stutter and not always keep accurate time. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/385bac3ec7ec0f42a9afe94b3f8fa47df59348a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -3 lines) Patch
M lib/src/runner/reporter/compact.dart View 7 chunks +22 lines, -1 line 0 comments Download
M test/runner/compact_reporter_test.dart View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nweiz
5 years, 5 months ago (2015-06-30 02:01:16 UTC) #1
kevmoo
LOVE IT One thing: when killing with Ctrl-C – you loose the 'waiting for test ...
5 years, 5 months ago (2015-06-30 04:40:31 UTC) #2
nweiz
On 2015/06/30 04:40:31, kevmoo wrote: > LOVE > IT > > One thing: when killing ...
5 years, 5 months ago (2015-06-30 19:25:24 UTC) #3
nweiz
On 2015/06/30 19:25:24, nweiz wrote: > On 2015/06/30 04:40:31, kevmoo wrote: > > LOVE > ...
5 years, 5 months ago (2015-06-30 19:25:44 UTC) #4
nweiz
Sorry, a *second* for it to be printed.
5 years, 5 months ago (2015-06-30 19:25:57 UTC) #5
nweiz
5 years, 5 months ago (2015-06-30 19:26:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
385bac3ec7ec0f42a9afe94b3f8fa47df59348a3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698