Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 12123002: Fix class patching involving type parameters: type parameters of patched classes (Closed)

Created:
7 years, 10 months ago by regis
Modified:
7 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix class patching involving type parameters: type parameters of patched classes were not finalized. Simplify and fix function type alias finalization (remove dummy alias owner). Make sure no unfinalized types or unresolved classes are written to a snapshot. Verify that all pending classes are finalized before writing a snapshot. Make snapshot_test more resilient to finalization errors. Add missing import to snapshot_test.dart. Fix typo in growable_array.dart. Committed: https://code.google.com/p/dart/source/detail?r=17962

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -161 lines) Patch
M runtime/lib/growable_array.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/class_finalizer.cc View 1 2 11 chunks +33 lines, -33 lines 0 comments Download
M runtime/vm/object.h View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 2 5 chunks +44 lines, -44 lines 0 comments Download
M runtime/vm/object_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser.cc View 1 2 14 chunks +81 lines, -36 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 2 4 chunks +14 lines, -39 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 1 2 3 chunks +7 lines, -4 lines 0 comments Download
M runtime/vm/snapshot_test.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/symbols.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
7 years, 10 months ago (2013-01-31 21:12:04 UTC) #1
siva
lgtm https://codereview.chromium.org/12123002/diff/10001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/12123002/diff/10001/runtime/vm/object.cc#newcode1921 runtime/vm/object.cc:1921: Class& result = Class::Handle(New<Instance>(name, script, token_pos)); const Class& ...
7 years, 10 months ago (2013-02-01 00:31:57 UTC) #2
regis
7 years, 10 months ago (2013-02-01 02:03:44 UTC) #3
Thanks!

https://codereview.chromium.org/12123002/diff/10001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/12123002/diff/10001/runtime/vm/object.cc#newc...
runtime/vm/object.cc:1921: Class& result = Class::Handle(New<Instance>(name,
script, token_pos));
On 2013/02/01 00:31:57, siva wrote:
> const Class& result?

Done.

https://codereview.chromium.org/12123002/diff/10001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/12123002/diff/10001/runtime/vm/parser.cc#newc...
runtime/vm/parser.cc:3402: Class& function_type_alias = Class::Handle(
On 2013/02/01 00:31:57, siva wrote:
> const Class& function_type......

Done.

Powered by Google App Engine
This is Rietveld 408576698