Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 1211993004: Dispose private cache partition on AnalysisContext.dispose(). (Closed)

Created:
5 years, 5 months ago by scheglov
Modified:
5 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Dispose private cache partition on AnalysisContext.dispose(). R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/18b3ab0c58c463bb112a18180d53cf0489f09897

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -9 lines) Patch
M pkg/analyzer/lib/src/context/cache.dart View 5 chunks +31 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/cache_test.dart View 2 chunks +52 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 5 months ago (2015-06-30 20:51:44 UTC) #1
Brian Wilkerson
LGTM
5 years, 5 months ago (2015-06-30 21:34:13 UTC) #2
scheglov
5 years, 5 months ago (2015-06-30 22:29:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
18b3ab0c58c463bb112a18180d53cf0489f09897 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698