Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1211993003: Get more tests passing using the new task model (Closed)

Created:
5 years, 6 months ago by Brian Wilkerson
Modified:
5 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -47 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 3 chunks +14 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/task/html.dart View 2 chunks +30 lines, -12 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 3 chunks +6 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 5 chunks +15 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 6 months ago (2015-06-25 20:47:47 UTC) #2
scheglov
LGTM
5 years, 6 months ago (2015-06-25 22:27:05 UTC) #3
Brian Wilkerson
5 years, 6 months ago (2015-06-26 14:43:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c9069537d8d1146a4a0a90232dd25df668e9e546 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698