Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 12118002: Fix for issue-7157 - set the stack marker in the top API local scope just before entering dart code… (Closed)

Created:
7 years, 10 months ago by siva
Modified:
7 years, 10 months ago
Reviewers:
Tom Ball
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix for issue-7157 - set the stack marker in the top API local scope just before entering dart code. It used to be set in Dart_EnterScope and this was causing problems as the marker could potentially end up being lower than the stack pointer at the time of entering Dart code resulting in an destruction of the top scope during 'state->UnwindScopes(...)' Committed: https://code.google.com/p/dart/source/detail?r=17939

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M vm/dart_api_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M vm/dart_api_state.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
7 years, 10 months ago (2013-01-30 23:27:44 UTC) #1
Tom Ball
LGTM -- the failing test now passes on Windows 7. Thanks!
7 years, 10 months ago (2013-01-31 00:04:47 UTC) #2
siva
Tom, I redid the changes a bit as a number of unit tests were failing ...
7 years, 10 months ago (2013-01-31 01:26:32 UTC) #3
Tom Ball
7 years, 10 months ago (2013-01-31 01:56:12 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698