Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1211743002: Flag --with-dartium should install dartium (Closed)

Created:
5 years, 6 months ago by danny
Modified:
5 years, 5 months ago
Reviewers:
Bill Hesse, kevmoo
CC:
reviews_dartlang.org, ricow1
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Flag --with-dartium should install dartium Although the --with-dartium flag was documented, the flag --with-content-shell was used for installing dartium instead. Chromium path in caveats should be version agnostic Fixes https://github.com/dart-lang/homebrew-dart/issues/32 R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/feade0551f099d5b4e59f0e96f8c16487b443d7f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/apps/update_homebrew/bin/update_homebrew.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Bill Hesse
LGTM
5 years, 6 months ago (2015-06-26 14:51:05 UTC) #2
Bill Hesse
Committed patchset #1 (id:1) manually as feade0551f099d5b4e59f0e96f8c16487b443d7f (presubmit successful).
5 years, 5 months ago (2015-07-01 08:25:08 UTC) #3
kevmoo
On 2015/07/01 08:25:08, Bill Hesse wrote: > Committed patchset #1 (id:1) manually as > feade0551f099d5b4e59f0e96f8c16487b443d7f ...
5 years, 5 months ago (2015-07-01 13:42:32 UTC) #4
Bill Hesse
5 years, 5 months ago (2015-07-01 13:45:44 UTC) #5
Message was sent while issue was closed. 
On 2015/07/01 13:42:32, kevmoo wrote:
> On 2015/07/01 08:25:08, Bill Hesse wrote:
> > Committed patchset #1 (id:1) manually as
> > feade0551f099d5b4e59f0e96f8c16487b443d7f (presubmit successful).
> 
> Oops!
> 
> ...love the self LGTM – didn't know that was a thing. :-)

This is actually a CL from Danny Kirchmeier, LGTM'd by me.  I didn't think he
could commit, so I committed it.  I tried to make him the author of the commit,
but failed.
Can we set the suthor of a git cl land commit?

Powered by Google App Engine
This is Rietveld 408576698