Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1211633002: Introduce mechanism to record an allocation of a class (Closed)

Created:
5 years, 6 months ago by Cutch
Modified:
5 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Introduce mechanism to record an allocation of a class - Use a bit in RawClass to remember if we are tracing allocation for this class. - Add Profiler::RecordAllocation - Add a simple heartbeat test for Profiler::RecordAllocation R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/26b5b2e95ba56429464bfd033e10753dbc4119de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -2 lines) Patch
M runtime/vm/object.h View 3 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 3 chunks +18 lines, -2 lines 0 comments Download
M runtime/vm/profiler.h View 2 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/profiler.cc View 1 chunk +52 lines, -0 lines 0 comments Download
M runtime/vm/profiler_test.cc View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 6 months ago (2015-06-24 18:11:10 UTC) #2
rmacnak
lgtm
5 years, 6 months ago (2015-06-24 20:39:17 UTC) #3
Cutch
5 years, 6 months ago (2015-06-24 20:41:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
26b5b2e95ba56429464bfd033e10753dbc4119de (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698