Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 1211523003: Remove BuildFunctionTypeAliasesTask. (Closed)

Created:
5 years, 6 months ago by Paul Berry
Modified:
5 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove BuildFunctionTypeAliasesTask. There seems to be no reason to do this as a separate step from ResolveUnitTypeNamesTask. R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/19d0ea816bfb0b8ba8f46a193639354f3273651a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -229 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 6 chunks +2 lines, -71 lines 0 comments Download
M pkg/analyzer/lib/src/plugin/engine_plugin.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 8 chunks +8 lines, -109 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart_work_manager.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 4 chunks +40 lines, -45 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Paul Berry
5 years, 6 months ago (2015-06-24 12:58:48 UTC) #2
Brian Wilkerson
LGTM
5 years, 6 months ago (2015-06-24 13:21:17 UTC) #3
scheglov
LGTM
5 years, 6 months ago (2015-06-24 13:50:17 UTC) #4
Paul Berry
5 years, 6 months ago (2015-06-24 15:08:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
19d0ea816bfb0b8ba8f46a193639354f3273651a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698