Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1211503003: dart2js: Fix nsm emitter in non-minified mode. (Closed)

Created:
5 years, 6 months ago by herhut
Modified:
5 years, 6 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -36 lines) Patch
M pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart View 1 6 chunks +39 lines, -36 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
herhut
5 years, 6 months ago (2015-06-25 08:55:27 UTC) #1
sigurdm
LGTM https://codereview.chromium.org/1211503003/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart File pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart (right): https://codereview.chromium.org/1211503003/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart#newcode137 pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:137: specialSelectors.map(namer.invocationMirrorInternalName); Indent https://codereview.chromium.org/1211503003/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart#newcode148 pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:148: [specialSelectors, ordinarySelectors].expand((e) => (e)); ...
5 years, 6 months ago (2015-06-25 09:15:00 UTC) #2
herhut
Committed patchset #2 (id:20001) manually as d5a57db06a2352fb7813313720c283be63c6d28b (presubmit successful).
5 years, 6 months ago (2015-06-25 09:21:17 UTC) #3
herhut
5 years, 6 months ago (2015-06-25 09:21:24 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/1211503003/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart (right):

https://codereview.chromium.org/1211503003/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:137:
specialSelectors.map(namer.invocationMirrorInternalName);
On 2015/06/25 09:15:00, sigurdm wrote:
> Indent

Done.

https://codereview.chromium.org/1211503003/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:148:
[specialSelectors, ordinarySelectors].expand((e) => (e));
On 2015/06/25 09:15:00, sigurdm wrote:
> Maybe call the special selectors intercepted selectors

Done.

Powered by Google App Engine
This is Rietveld 408576698