Issue 12114039: Fixing xhr_test's responseType test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12114039: Fixing xhr_test's responseType test. (Closed)

Created:
7 years, 10 months ago by blois

Modified:
7 years, 10 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing xhr_test's responseType test. The responseType being set was not supported by Dartium or Safari. BUG= Committed: https://code.google.com/p/dart/source/detail?r=17959

Patch Set 1 #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	tests/html/xhr_test.dart	View		1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

7 years, 10 months ago (2013-02-01 00:14:47 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/12114039/diff/1/tests/html/xhr_test.dart
File tests/html/xhr_test.dart (right):

https://codereview.chromium.org/12114039/diff/1/tests/html/xhr_test.dart#newc...
tests/html/xhr_test.dart:129: HttpRequest.request(url, responseType:
'arraybuffer').then(
lgtm. can you add a comment on the appropriate function saying that the
responseType value needs to be "arraybuffer" (and the other options), so people
don't get confused? Later, enums?

Expand Messages | Collapse Messages