Issue 1211393003: dart2js cps: Fix translation of local constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1211393003: dart2js cps: Fix translation of local constants. (Closed)

Created:
5 years, 6 months ago by asgerf

Modified:
5 years, 5 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -17 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart	View		1 chunk	+12 lines, -17 lines	0 comments	Download

Total messages: 5 (1 generated)

Kevin Millikin (Google)

LGTM. Does this require updating the test status files?

5 years, 5 months ago (2015-06-29 10:32:16 UTC) #3

asgerf

On 2015/06/29 10:32:16, Kevin Millikin (Google) wrote: > LGTM. Does this require updating the test ...

5 years, 5 months ago (2015-06-29 10:33:11 UTC) #4

asgerf

5 years, 5 months ago (2015-06-29 12:32:54 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
ec55d4614849f4b8edfbe695486ed916f39a1603 (presubmit successful).