Issue 1211223002: Mark static function getters as used in codegen.

Issue 1211223002: Mark static function getters as used in codegen. (Closed)

Created:
5 years, 6 months ago by sra1

Modified:
5 years, 6 months ago

Reviewers:
ahe, floitsch, Siggi Cherem (dart-lang), dart2js-team

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Mark static function getters as used in codegen. Move marking from SSA builder to codegen. If the only a reference to (a closure over a) static or top level function is optimized away, it is no longer retained in the generated code. R=ahe@google.com, sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/4d784a7d0165aa768695d5d185c6b82c29501759 Reverted. Committed: https://github.com/dart-lang/sdk/commit/7d6051f21e84ec4bf2312b854a0e2c990ea88361

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -4 lines)			Patch
M	pkg/compiler/lib/src/ssa/builder.dart	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/codegen.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download
A	tests/compiler/dart2js/top_level_closure_tree_shake_test.dart	View	1 2	1 chunk	+38 lines, -0 lines	0 comments	Download

Total messages: 9 (3 generated)

sra1

Committed patchset #2 (id:20001) manually as 4d784a7d0165aa768695d5d185c6b82c29501759 (presubmit successful).

5 years, 6 months ago (2015-06-26 03:29:51 UTC) #4

sra1

5 years, 6 months ago (2015-06-26 15:36:28 UTC) #9

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
7d6051f21e84ec4bf2312b854a0e2c990ea88361 (presubmit successful).