Extend allocation profile testing

Extend allocation profile testing

- Add ProfileTrieWalker to help with testing.
- Extend allocation profile test to check for expected stack trace.
- Don't inline allocation of class when allocation tracing is enabled.

Dependency: https://codereview.chromium.org/1210333002/

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/bb934552ead6e82a1001727331d0e741adfb87c7

[Cutch, 2015-06-26 13:49:35]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2015-06-26 17:55:58]

lgtm

https://chromiumcodereview.appspot.com/1210283003/diff/1/runtime/vm/profiler_...
File runtime/vm/profiler_service.cc (right):

https://chromiumcodereview.appspot.com/1210283003/diff/1/runtime/vm/profiler_...
runtime/vm/profiler_service.cc:112: const String& func_name =
String::Handle(function_.UserVisibleName());
QualifiedUserVisibleName

https://chromiumcodereview.appspot.com/1210283003/diff/1/runtime/vm/profiler_...
File runtime/vm/profiler_test.cc (right):

https://chromiumcodereview.appspot.com/1210283003/diff/1/runtime/vm/profiler_...
runtime/vm/profiler_test.cc:185: // Exclusive function: boo -> main.
B.boo

[Cutch, 2015-06-26 18:02:49]

https://codereview.chromium.org/1210283003/diff/1/runtime/vm/profiler_service.cc
File runtime/vm/profiler_service.cc (right):

https://codereview.chromium.org/1210283003/diff/1/runtime/vm/profiler_service...
runtime/vm/profiler_service.cc:112: const String& func_name =
String::Handle(function_.UserVisibleName());
On 2015/06/26 17:55:57, rmacnak wrote:
> QualifiedUserVisibleName

Done.

https://codereview.chromium.org/1210283003/diff/1/runtime/vm/profiler_test.cc
File runtime/vm/profiler_test.cc (right):

https://codereview.chromium.org/1210283003/diff/1/runtime/vm/profiler_test.cc...
runtime/vm/profiler_test.cc:185: // Exclusive function: boo -> main.
On 2015/06/26 17:55:58, rmacnak wrote:
> B.boo

Done.

[srdjan, 2015-06-26 18:18:22]

srdjan@google.com changed reviewers:
+ srdjan@google.com

[srdjan, 2015-06-26 18:18:22]

dbc

https://codereview.chromium.org/1210283003/diff/20001/runtime/vm/profiler_ser...
File runtime/vm/profiler_service.h (right):

https://codereview.chromium.org/1210283003/diff/20001/runtime/vm/profiler_ser...
runtime/vm/profiler_service.h:339: class ProfileTrieWalker {
Please subclass from a meaningful class (ValueObject, ..).

https://codereview.chromium.org/1210283003/diff/20001/runtime/vm/stub_code_ia...
File runtime/vm/stub_code_ia32.cc (right):

https://codereview.chromium.org/1210283003/diff/20001/runtime/vm/stub_code_ia...
runtime/vm/stub_code_ia32.cc:1058: if (FLAG_inline_alloc &&
Heap::IsAllocatableInNewSpace(instance_size) &&
You may want to run all tests with --vm-options=--no-inline-alloc, to make sure
that code still works.

[Cutch, 2015-06-26 19:21:41]

https://codereview.chromium.org/1210283003/diff/20001/runtime/vm/profiler_ser...
File runtime/vm/profiler_service.h (right):

https://codereview.chromium.org/1210283003/diff/20001/runtime/vm/profiler_ser...
runtime/vm/profiler_service.h:339: class ProfileTrieWalker {
On 2015/06/26 18:18:22, srdjan wrote:
> Please subclass from a meaningful class (ValueObject, ..).

Done.

https://codereview.chromium.org/1210283003/diff/20001/runtime/vm/stub_code_ia...
File runtime/vm/stub_code_ia32.cc (right):

https://codereview.chromium.org/1210283003/diff/20001/runtime/vm/stub_code_ia...
runtime/vm/stub_code_ia32.cc:1058: if (FLAG_inline_alloc &&
Heap::IsAllocatableInNewSpace(instance_size) &&
On 2015/06/26 18:18:22, srdjan wrote:
> You may want to run all tests with --vm-options=--no-inline-alloc, to make
sure
> that code still works.

$ ./tools/test.py --vm-options=--no-inline-alloc
[07:31 | 100% | +13069 | -    0]

[Cutch, 2015-06-26 19:22:13]

Committed patchset #3 (id:40001) manually as
bb934552ead6e82a1001727331d0e741adfb87c7 (presubmit successful).