Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1210213002: Allow 'guess_other_cid' for noopt as we do not have any type feedback at all (still investigating r… (Closed)

Created:
5 years, 6 months ago by srdjan
Modified:
5 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow 'guess_other_cid' for noopt as we do not have any type feedback at all (still investigating range analysis crash when running with type feedback) BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/6e8f867fc1496806d24f14d0666219bcdb842e62

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/vm/flow_graph_compiler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
srdjan
5 years, 6 months ago (2015-06-25 19:33:01 UTC) #2
rmacnak
lgtm
5 years, 6 months ago (2015-06-25 19:38:55 UTC) #3
srdjan
5 years, 6 months ago (2015-06-25 19:40:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6e8f867fc1496806d24f14d0666219bcdb842e62 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698