Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 12100003: Fix debugger test that broke with the change to the json library. (Closed)

Created:
7 years, 10 months ago by Mads Ager (google)
Modified:
7 years, 10 months ago
Reviewers:
Bill Hesse, hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix debugger test that broke with the change to the json library. Added checking of the debugger subprocess exit code that would have caught this. R=whesse@google.com,hausner@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=17846

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tests/standalone/debugger/debug_lib.dart View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
7 years, 10 months ago (2013-01-30 13:54:20 UTC) #1
Bill Hesse
7 years, 10 months ago (2013-01-30 14:22:31 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698