Issue 12096105: Instead of setting up the can intrinsify state lazily setup eagerly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12096105: Instead of setting up the can intrinsify state lazily setup eagerly (Closed)

Created:
7 years, 10 months ago by siva

Modified:
7 years, 10 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Instead of setting up the can intrinsify state lazily setup eagerly in Object::Init() so that the snapshot will carry it and when running from a snapshot Intrinsifier::CanIntrinsify can be just a bit check. Committed: https://code.google.com/p/dart/source/detail?r=17995

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -79 lines)			Patch
M	vm/intrinsifier.h	View	1 2	5 chunks	+20 lines, -8 lines	0 comments	Download
M	vm/intrinsifier.cc	View	1 2	4 chunks	+60 lines, -53 lines	0 comments	Download
M	vm/object.h	View	1 2	3 chunks	+6 lines, -15 lines	0 comments	Download
M	vm/object.cc	View	1 2	4 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages