Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 12096042: Remove import of collection-dev. (Closed)

Created:
7 years, 10 months ago by floitsch
Modified:
7 years, 10 months ago
Reviewers:
Alan Knight, blois
CC:
reviews_dartlang.org, Lasse Reichstein Nielsen
Visibility:
Public.

Description

Remove import of collection-dev. Committed: https://code.google.com/p/dart/source/detail?r=17802

Patch Set 1 #

Total comments: 1

Patch Set 2 : Keep collection-dev in js-library for now. #

Patch Set 3 : Really keep collection-dev in js-library for now. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -24 lines) Patch
M pkg/serialization/lib/serialization.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/serialization/lib/src/format.dart View 1 chunk +1 line, -6 lines 0 comments Download
M samples/swarm/swarm_ui_lib/observable/observable.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_helper.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/html/html_common/html_common.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/html/html_common/html_common_dart2js.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/svg_dart2js.darttemplate View 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/web_audio_dart2js.darttemplate View 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/templates/html/dartium/svg_dartium.darttemplate View 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/templates/html/dartium/web_audio_dartium.darttemplate View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
floitsch
7 years, 10 months ago (2013-01-29 18:49:49 UTC) #1
blois
HTML changes LGTM But I'm getting a compilation error in dart2js with this change (running ...
7 years, 10 months ago (2013-01-29 19:03:52 UTC) #2
floitsch
On 2013/01/29 19:03:52, blois wrote: > HTML changes LGTM > > But I'm getting a ...
7 years, 10 months ago (2013-01-29 19:10:44 UTC) #3
Alan Knight
7 years, 10 months ago (2013-01-29 19:15:23 UTC) #4
lgtm, though I wish we had a better solution for that.

https://codereview.chromium.org/12096042/diff/1/pkg/serialization/lib/src/for...
File pkg/serialization/lib/src/format.dart (right):

https://codereview.chromium.org/12096042/diff/1/pkg/serialization/lib/src/for...
pkg/serialization/lib/src/format.dart:187: var newData = mapValues(data, (x) =>
recursivelyFixUp(x, r, result));
Not a lot prettier than what it's replacing, but it works and it avoids the
import.

Powered by Google App Engine
This is Rietveld 408576698