Issue 12095034: dart2js: Don't emit static const fields since they are inlined where they are used

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12095034: dart2js: Don't emit static const fields since they are inlined where they are used (Closed)

Created:
7 years, 10 months ago by erikcorry

Modified:
7 years, 10 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart2js: Don't emit static const fields since they are inlined where they are used R=ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=17753

Patch Set 1 #

Total comments: 2

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -1 line)			Patch
M	sdk/lib/_internal/compiler/implementation/compile_time_constants.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
A	tests/compiler/dart2js/emit_const_fields_test.dart	View	1 chunk	+25 lines, -0 lines	2 comments	Download
A	tests/language/emit_const_fields_test.dart	View	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/12095034/diff/1/tests/compiler/dart2js/emit_const_fields_test.dart File tests/compiler/dart2js/emit_const_fields_test.dart (right): https://codereview.chromium.org/12095034/diff/1/tests/compiler/dart2js/emit_const_fields_test.dart#newcode7 tests/compiler/dart2js/emit_const_fields_test.dart:7: import 'parser_helper.dart'; Do you need parser_helper?

7 years, 10 months ago (2013-01-29 11:19:38 UTC) #2

erikcorry

7 years, 10 months ago (2013-02-04 11:38:01 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/12095034/diff/1/tests/compiler/dart2js/emit_c...
File tests/compiler/dart2js/emit_const_fields_test.dart (right):

https://codereview.chromium.org/12095034/diff/1/tests/compiler/dart2js/emit_c...
tests/compiler/dart2js/emit_const_fields_test.dart:7: import
'parser_helper.dart';
On 2013/01/29 11:19:38, ngeoffray wrote:
> Do you need parser_helper?

No.

Removed.

Expand Messages | Collapse Messages