Issue 12094093: Add a validator that tests the size of pub packages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12094093: Add a validator that tests the size of pub packages. (Closed)

Created:
7 years, 10 months ago by nweiz

Modified:
7 years, 10 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a validator that tests the size of pub packages. BUG=7045 Committed: https://code.google.com/p/dart/source/detail?r=17961

Patch Set 1 #

Total comments: 4

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -12 lines)			Patch
M	utils/pub/command_lish.dart	View	2 chunks	+12 lines, -11 lines	0 comments	Download
M	utils/pub/validator.dart	View	3 chunks	+9 lines, -1 line	0 comments	Download
A	utils/pub/validator/size.dart	View	1 chunk	+32 lines, -0 lines	4 comments	Download
M	utils/tests/pub/validator_test.dart	View	5 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

Couple of nits. Otherwise LGTM. https://codereview.chromium.org/12094093/diff/1/utils/pub/validator/size.dart File utils/pub/validator/size.dart (right): https://codereview.chromium.org/12094093/diff/1/utils/pub/validator/size.dart#newcode14 utils/pub/validator/size.dart:14: final _MAX_SIZE = 10 ...

7 years, 10 months ago (2013-02-01 01:29:44 UTC) #2

nweiz

7 years, 10 months ago (2013-02-01 02:08:00 UTC) #3

https://codereview.chromium.org/12094093/diff/1/utils/pub/validator/size.dart
File utils/pub/validator/size.dart (right):

https://codereview.chromium.org/12094093/diff/1/utils/pub/validator/size.dart...
utils/pub/validator/size.dart:14: final _MAX_SIZE = 10 * math.pow(2, 20);
On 2013/02/01 01:29:44, Bob Nystrom wrote:
> This should either be _maxSize (since it's not const) or:
> 
> const _MAX_SIZE = 10 * 1024 * 1024;

Done.

https://codereview.chromium.org/12094093/diff/1/utils/pub/validator/size.dart...
utils/pub/validator/size.dart:28: "10 MB large.");
On 2013/02/01 01:29:44, Bob Nystrom wrote:
> How about "Hosted packages must be smaller than 10 MB."
> 
> (I realize that's not strictly accurate if the package happens to be exactly
> 10MB, but it reads nicely.)

Done.

Expand Messages | Collapse Messages