Issue 12094092: Update expected result.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12094092: Update expected result. (Closed)

Created:
7 years, 10 months ago by siva

Modified:
7 years, 10 months ago

Reviewers:
Tom Ball

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/tests/

Visibility:
Public.

More Reviews

Description

Update expected result. Committed: https://code.google.com/p/dart/source/detail?r=17950

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	standalone/io/test_extension_fail_test.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Tom Ball

https://codereview.chromium.org/12094092/diff/1/standalone/io/test_extension_fail_test.dart File standalone/io/test_extension_fail_test.dart (right): https://codereview.chromium.org/12094092/diff/1/standalone/io/test_extension_fail_test.dart#newcode63 standalone/io/test_extension_fail_test.dart:63: Expect.isTrue(result.stderr.contains("ball\n")); This won't work, because the Windows line ending ...

7 years, 10 months ago (2013-01-31 22:33:47 UTC) #2

siva

https://codereview.chromium.org/12094092/diff/1/standalone/io/test_extension_fail_test.dart File standalone/io/test_extension_fail_test.dart (right): https://codereview.chromium.org/12094092/diff/1/standalone/io/test_extension_fail_test.dart#newcode63 standalone/io/test_extension_fail_test.dart:63: Expect.isTrue(result.stderr.contains("ball\n")); Good point, changed test per offline discussion. On ...

7 years, 10 months ago (2013-01-31 22:35:50 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages

Issue 12094092: Update expected result. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages