Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issue 12093044: Utilize all cores on IE bots (Closed)

Created:
7 years, 10 months ago by kustermann
Modified:
7 years, 10 months ago
Reviewers:
ricow1, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Utilize all cores on IE bots Committed: https://code.google.com/p/dart/source/detail?r=17771

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M tools/bots/compiler.py View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/test.dart View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
kustermann
7 years, 10 months ago (2013-01-29 15:37:21 UTC) #1
ricow1
lgtm https://codereview.chromium.org/12093044/diff/1/tools/bots/compiler.py File tools/bots/compiler.py (left): https://codereview.chromium.org/12093044/diff/1/tools/bots/compiler.py#oldcode168 tools/bots/compiler.py:168: # http://code.google.com/p/selenium/wiki/InternetExplorerDriver. You could copy this comment to ...
7 years, 10 months ago (2013-01-29 15:41:17 UTC) #2
kustermann
https://codereview.chromium.org/12093044/diff/1/tools/bots/compiler.py File tools/bots/compiler.py (left): https://codereview.chromium.org/12093044/diff/1/tools/bots/compiler.py#oldcode168 tools/bots/compiler.py:168: # http://code.google.com/p/selenium/wiki/InternetExplorerDriver. On 2013/01/29 15:41:17, ricow1 wrote: > You ...
7 years, 10 months ago (2013-01-29 16:08:55 UTC) #3
Emily Fortuna
awesome they fixed that!
7 years, 10 months ago (2013-01-29 18:21:46 UTC) #4
ahe
Awesome!
7 years, 10 months ago (2013-01-29 18:21:48 UTC) #5
ricow1
7 years, 10 months ago (2013-01-29 18:35:27 UTC) #6
Message was sent while issue was closed.
On 2013/01/29 18:21:46, Emily Fortuna wrote:
> awesome they fixed that!

They actually did not fix it, but Martin made the testing scripts utilize the
cores better by allowing up to #cores simultaniuos compilations, still only
allowing 1 ie to run at a time.
This almost have the same effect though - since we spend 90% of the time
compiling on most commits

Powered by Google App Engine
This is Rietveld 408576698