Issue 12092118: Change the way that events are annotated.

Issue 12092118: Change the way that events are annotated. (Closed)

Created:
7 years, 10 months ago by Andrei Mouravski

Modified:
7 years, 10 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change the way that events are annotated. Committed: https://code.google.com/p/dart/source/detail?r=18053

Patch Set 2 : Line length. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1149 lines, -1173 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		58 chunks	+467 lines, -481 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		58 chunks	+468 lines, -482 lines	0 comments	Download
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View		10 chunks	+22 lines, -22 lines	0 comments	Download
M	sdk/lib/indexed_db/dartium/indexed_db_dartium.dart	View		10 chunks	+22 lines, -22 lines	0 comments	Download
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View	1	2 chunks	+80 lines, -80 lines	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View	1	2 chunks	+80 lines, -80 lines	0 comments	Download
M	sdk/lib/web_audio/dart2js/web_audio_dart2js.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/web_audio/dartium/web_audio_dartium.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/dom/scripts/htmleventgenerator.py	View	1	3 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

lgtm https://codereview.chromium.org/12092118/diff/1/tools/dom/scripts/htmleventgenerator.py File tools/dom/scripts/htmleventgenerator.py (right): https://codereview.chromium.org/12092118/diff/1/tools/dom/scripts/htmleventgenerator.py#newcode400 tools/dom/scripts/htmleventgenerator.py:400: GetAnnotationsAndComments(library_name, interface.id, annotation_name), ' ') line length https://codereview.chromium.org/12092118/diff/1/tools/dom/scripts/htmleventgenerator.py#newcode430 ...

7 years, 10 months ago (2013-02-01 22:12:55 UTC) #2

Andrei Mouravski

7 years, 10 months ago (2013-02-04 16:03:12 UTC) #3

Thanks! Submitting.

https://codereview.chromium.org/12092118/diff/1/tools/dom/scripts/htmleventge...
File tools/dom/scripts/htmleventgenerator.py (right):

https://codereview.chromium.org/12092118/diff/1/tools/dom/scripts/htmleventge...
tools/dom/scripts/htmleventgenerator.py:400:
GetAnnotationsAndComments(library_name, interface.id, annotation_name), '  ')
On 2013/02/01 22:12:55, blois wrote:
> line length

Done.

https://codereview.chromium.org/12092118/diff/1/tools/dom/scripts/htmleventge...
tools/dom/scripts/htmleventgenerator.py:430:
GetAnnotationsAndComments(library_name, interface.id, annotation_name), '  ')
On 2013/02/01 22:12:55, blois wrote:
> line length

Done.

Expand Messages | Collapse Messages