Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 12092020: Revert "Fix VariableDefinitions.endToken for formal parameters." (Closed)

Created:
7 years, 10 months ago by Johnni Winther
Modified:
7 years, 10 months ago
Reviewers:
ahe, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Fix VariableDefinitions.endToken for formal parameters." This reverts commit r17705. Committed: https://code.google.com/p/dart/source/detail?r=17710

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -82 lines) Patch
M sdk/lib/_internal/compiler/implementation/dart_backend/utils.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 2 chunks +3 lines, -29 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/listener.dart View 6 chunks +10 lines, -10 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/tree/nodes.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/tree/unparser.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/unparser_test.dart View 2 chunks +0 lines, -38 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
TBR Problems with for-in :(
7 years, 10 months ago (2013-01-28 13:41:40 UTC) #1
kasperl
LGTM. Thanks, Johnni!
7 years, 10 months ago (2013-01-28 13:43:05 UTC) #2
ahe
7 years, 10 months ago (2013-01-28 15:02:28 UTC) #3
Message was sent while issue was closed.
lgtm

:-(

Powered by Google App Engine
This is Rietveld 408576698