Issue 12091092: Ensure all UnknowConcreteTypes are const so that their equality test is sound.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12091092: Ensure all UnknowConcreteTypes are const so that their equality test is sound. (Closed)

Created:
7 years, 10 months ago by polux

Modified:
7 years, 10 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Ensure all UnknowConcreteTypes are const so that their equality test is sound. Committed: https://code.google.com/p/dart/source/detail?r=18509

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

karlklose

LGTM. You could also change UnknownConcreteType.operator== to check 'other is UnknownCocreteType'.

7 years, 10 months ago (2013-02-01 08:03:24 UTC) #2

polux

On 2013/02/01 08:03:24, karlklose wrote: > LGTM. > > You could also change UnknownConcreteType.operator== to ...

7 years, 10 months ago (2013-02-01 08:21:48 UTC) #3

Yes, it would be slower.