Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 12091067: Revert "Fix debugger test that broke with the change to the json library." (Closed)

Created:
7 years, 10 months ago by Mads Ager (google)
Modified:
7 years, 10 months ago
Reviewers:
Bill Hesse, hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Fix debugger test that broke with the change to the json library." Unfortunately, the buildbots did not like that. Reverting back to the broken test. R=whesse@google.com,hausner@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=17849

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M tests/standalone/debugger/debug_lib.dart View 2 chunks +1 line, -2 lines 3 comments Download

Messages

Total messages: 5 (0 generated)
Mads Ager (google)
7 years, 10 months ago (2013-01-30 15:24:40 UTC) #1
Bill Hesse
LGTM https://codereview.chromium.org/12091067/diff/1/tests/standalone/debugger/debug_lib.dart File tests/standalone/debugger/debug_lib.dart (right): https://codereview.chromium.org/12091067/diff/1/tests/standalone/debugger/debug_lib.dart#newcode52 tests/standalone/debugger/debug_lib.dart:52: // Returns the character length of the newxt ...
7 years, 10 months ago (2013-01-30 16:04:09 UTC) #2
Mads Ager (google)
Bill, this was a pure revert. If I remove the JSON prefixes I think this ...
7 years, 10 months ago (2013-01-30 16:09:15 UTC) #3
hausner
lgtm
7 years, 10 months ago (2013-01-30 16:12:59 UTC) #4
hausner
7 years, 10 months ago (2013-01-30 16:12:59 UTC) #5
Message was sent while issue was closed.
lgtm

lgtm

Powered by Google App Engine
This is Rietveld 408576698