Issue 12091026: Serialization shouldn't modify the keys of a map it's iterating over

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12091026: Serialization shouldn't modify the keys of a map it's iterating over (Closed)

Created:
7 years, 10 months ago by Alan Knight

Modified:
7 years, 10 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Serialization shouldn't modify the keys of a map it's iterating over Committed: https://code.google.com/p/dart/source/detail?r=17727

Patch Set 1 #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -15 lines)			Patch
	M	pkg/serialization/lib/src/basic_rule.dart	View		1 chunk	+14 lines, -15 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alan Knight

TBR. News flash. Iterating over the keys of a map and modifying the map is ...

7 years, 10 months ago (2013-01-28 18:55:22 UTC) #1

Jennifer Messerly

7 years, 10 months ago (2013-01-28 19:45:00 UTC) #2

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/12091026/diff/1/pkg/serialization/lib/src/bas...
File pkg/serialization/lib/src/basic_rule.dart (right):

https://codereview.chromium.org/12091026/diff/1/pkg/serialization/lib/src/bas...
pkg/serialization/lib/src/basic_rule.dart:152: var newState = new Map();
one idea that might help, if the perf here is noticeable, you could scan the map
first for a Reference, and avoid allocating the new one unless you know
something needs to be replaced.

Expand Messages | Collapse Messages