Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 12091006: Fixing element_test on Safari. (Closed)

Created:
7 years, 11 months ago by blois
Modified:
7 years, 10 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing element_test on Safari. I changed computedStyle to getComputedStyle, but forgot this location. But this test was not in a group, which with the individual config should have made the test not execute. But on Safari it's failing all of the element_test tests. Odd thing is that it's not failing on the rest of the browsers. Also adding a small delay for the setTimeout case as IE appears to be optimizing the 0 condition (in some cases). TBR BUG= Committed: https://code.google.com/p/dart/source/detail?r=17683

Patch Set 1 #

Patch Set 2 : Adding a delay for setTimeout as well. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -26 lines) Patch
M tests/html/element_test.dart View 1 chunk +26 lines, -25 lines 0 comments Download
M tests/html/microtask_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
blois
7 years, 11 months ago (2013-01-26 01:28:21 UTC) #1
Emily Fortuna
7 years, 10 months ago (2013-01-28 22:59:52 UTC) #2
Message was sent while issue was closed.
Hmm. That seems worrisome with the tests failing on Safari even though they
shouldn't have been run.... If you get a chance, file an issue on me and I'll
investigate.

lgtm.

Powered by Google App Engine
This is Rietveld 408576698