Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 12090104: Stop using cURL in Pub. (Closed)

Created:
7 years, 10 months ago by nweiz
Modified:
7 years, 10 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Stop using cURL in Pub. BUG=7395 Committed: https://code.google.com/p/dart/source/detail?r=18007

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4673 lines) Patch
D third_party/curl/ca-certificates.crt View 1 chunk +0 lines, -3871 lines 0 comments Download
D third_party/curl/curl.LICENSE View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/curl/curl.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/curl/openssl.LICENSE View 1 chunk +0 lines, -126 lines 0 comments Download
D utils/pub/curl_client.dart View 1 chunk +0 lines, -198 lines 0 comments Download
M utils/pub/hosted_source.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/http.dart View 3 chunks +10 lines, -9 lines 0 comments Download
M utils/pub/oauth2.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/pub/pub.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A utils/pub/resource/certs/cert9.db View 0 chunks +-1 lines, --1 lines 0 comments Download
A utils/pub/resource/certs/key4.db View 0 chunks +-1 lines, --1 lines 0 comments Download
A utils/pub/resource/certs/pkcs11.txt View 1 chunk +5 lines, -0 lines 0 comments Download
D utils/tests/pub/curl_client_test.dart View 1 chunk +0 lines, -447 lines 0 comments Download
M utils/tests/pub/pub.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
nweiz
7 years, 10 months ago (2013-01-31 23:46:28 UTC) #1
Bob Nystrom
7 years, 10 months ago (2013-02-01 21:23:49 UTC) #2
LGTM. Heck to the yes.

Powered by Google App Engine
This is Rietveld 408576698