Issue 12090067: Speculative fix for flakines on browser bots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12090067: Speculative fix for flakines on browser bots (Closed)

Created:
7 years, 10 months ago by ricow1

Modified:
7 years, 10 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Speculative fix for flakines on browser bots Committed: https://code.google.com/p/dart/source/detail?r=17827

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -12 lines)			Patch
	M	tools/testing/run_selenium.py	View	1	2 chunks	+9 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kustermann

LGTM with comments https://codereview.chromium.org/12090067/diff/1/tools/testing/run_selenium.py File tools/testing/run_selenium.py (right): https://codereview.chromium.org/12090067/diff/1/tools/testing/run_selenium.py#newcode97 tools/testing/run_selenium.py:97: pass The "pass" should not be ...

7 years, 10 months ago (2013-01-30 09:52:02 UTC) #2

ricow1

7 years, 10 months ago (2013-01-30 09:54:45 UTC) #3

thanks, landing

https://codereview.chromium.org/12090067/diff/1/tools/testing/run_selenium.py
File tools/testing/run_selenium.py (right):

https://codereview.chromium.org/12090067/diff/1/tools/testing/run_selenium.py...
tools/testing/run_selenium.py:97: pass
On 2013/01/30 09:52:02, kustermann wrote:
> The "pass" should not be necessary here.

removed

https://codereview.chromium.org/12090067/diff/1/tools/testing/run_selenium.py...
tools/testing/run_selenium.py:248: browser.quit()
On 2013/01/30 09:52:02, kustermann wrote:
> I think this should be indented one level to the left?!

good catch

Expand Messages | Collapse Messages

Issue 12090067: Speculative fix for flakines on browser bots (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages