Issue 12090035: Split the comment strings in docs extraction on newlines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12090035: Split the comment strings in docs extraction on newlines. (Closed)

Created:
7 years, 10 months ago by Andrei Mouravski

Modified:
7 years, 10 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Split the comment strings in docs extraction on newlines. Committed: https://code.google.com/p/dart/source/detail?r=17796

Patch Set 1 #

Patch Set 2 : Fixed indentation. #

Patch Set 3 : Merged master. #

Total comments: 2

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+131 lines, -8 lines)			Patch
M	tools/dom/docs/docs.json	View	1 2	2 chunks	+111 lines, -5 lines	0 comments	Download
M	tools/dom/docs/lib/docs.dart	View	1	4 chunks	+17 lines, -3 lines	1 comment	Download
M	tools/dom/scripts/generator.py	View	1 2	1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

blois

7 years, 10 months ago (2013-01-29 16:53:31 UTC) #2

lgtm

https://codereview.chromium.org/12090035/diff/1002/tools/dom/docs/lib/docs.dart
File tools/dom/docs/lib/docs.dart (right):

https://codereview.chromium.org/12090035/diff/1002/tools/dom/docs/lib/docs.da...
tools/dom/docs/lib/docs.dart:165: comments.forEach((c) {
nit- I prefer for () loops over forEach for standard loops like this.

https://codereview.chromium.org/12090035/diff/1002/tools/dom/scripts/generato...
File tools/dom/scripts/generator.py (right):

https://codereview.chromium.org/12090035/diff/1002/tools/dom/scripts/generato...
tools/dom/scripts/generator.py:835: if (len(comments)):
unnecessary parens, and I believe you can just do:
if comments:

Expand Messages | Collapse Messages