Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 12090034: Initial revision of ARM assembler. (Closed)

Created:
7 years, 10 months ago by regis
Modified:
7 years, 10 months ago
Reviewers:
srdjan, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Initial revision of ARM assembler. Object references and calls, as well as their fixups, are still unimplemented. Committed: https://code.google.com/p/dart/source/detail?r=17775

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2070 lines, -140 lines) Patch
M runtime/vm/assembler.cc View 1 2 2 chunks +31 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm.h View 1 2 4 chunks +521 lines, -70 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 1 2 1 chunk +1483 lines, -2 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 1 2 2 chunks +0 lines, -29 lines 0 comments Download
M runtime/vm/assembler_mips.h View 1 2 2 chunks +22 lines, -7 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 2 2 chunks +0 lines, -29 lines 0 comments Download
M runtime/vm/constants_arm.h View 1 2 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
regis
7 years, 10 months ago (2013-01-29 00:49:20 UTC) #1
srdjan
7 years, 10 months ago (2013-01-29 01:14:58 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698