Issue 12088044: Issue 8169. Type inferred from 'query' is 'inferred exact'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12088044: Issue 8169. Type inferred from 'query' is 'inferred exact'. (Closed)

Created:
7 years, 10 months ago by scheglov

Modified:
7 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 8169. Type inferred from 'query' is 'inferred exact'. http://code.google.com/p/dart/issues/detail?id=8169 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=17795

Patch Set 1 #

Patch Set 2 : Don't report problem when member exists, but not the unique. #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -40 lines)			Patch
M	compiler/java/com/google/dart/compiler/type/DynamicTypeImplementation.java	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/ExternalTypeAnalyzers.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/InterfaceType.java	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/InterfaceTypeImplementation.java	View	1	2 chunks	+16 lines, -24 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/InterfaceTypeUnionImplementation.java	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View	1	3 chunks	+21 lines, -7 lines	1 comment	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

7 years, 10 months ago (2013-01-29 18:32:33 UTC) #4

LGTM

https://codereview.chromium.org/12088044/diff/4001/compiler/java/com/google/d...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://codereview.chromium.org/12088044/diff/4001/compiler/java/com/google/d...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:2404: // is
"receiver" is inferred, attempt to find member in one of the subtypes
In code review, this line appears to be duplicated. It probably isn't, but
please check.

Expand Messages | Collapse Messages