Issue 12087112: Can now correctly add documentation to constructors.

Issue 12087112: Can now correctly add documentation to constructors. (Closed)

Created:
7 years, 10 months ago by Andrei Mouravski

Modified:
7 years, 10 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Can now correctly add documentation to constructors. Committed: https://code.google.com/p/dart/source/detail?r=17954

Patch Set 3 : #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+477 lines, -39 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		90 chunks	+153 lines, -0 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		87 chunks	+150 lines, -0 lines	0 comments	Download
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View		48 chunks	+48 lines, -0 lines	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View		48 chunks	+48 lines, -0 lines	0 comments	Download
M	sdk/lib/web_audio/dart2js/web_audio_dart2js.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/web_audio/dartium/web_audio_dartium.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/docs/docs.json	View		1 chunk	+20 lines, -1 line	0 comments	Download
M	tools/dom/scripts/generator.py	View	1 2	3 chunks	+11 lines, -14 lines	1 comment	Download
M	tools/dom/scripts/htmldartgenerator.py	View	1 2	7 chunks	+36 lines, -15 lines	0 comments	Download
M	tools/dom/scripts/htmleventgenerator.py	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1 2	2 chunks	+5 lines, -4 lines	0 comments	Download
M	tools/dom/scripts/systemnative.py	View	1 2	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

blois

On 2013/01/31 20:38:18, Andrei Mouravski wrote: lgtm, but I really think that the library_name situation ...

7 years, 10 months ago (2013-01-31 20:45:20 UTC) #2

blois

https://codereview.chromium.org/12087112/diff/2001/tools/dom/docs/docs.json File tools/dom/docs/docs.json (right): https://codereview.chromium.org/12087112/diff/2001/tools/dom/docs/docs.json#newcode228 tools/dom/docs/docs.json:228: " * var request = new HttpRequest.get('http://dartlang.org', (event) => ...

7 years, 10 months ago (2013-01-31 20:45:28 UTC) #3

Andrei Mouravski

PTAL. https://codereview.chromium.org/12087112/diff/2001/tools/dom/docs/docs.json File tools/dom/docs/docs.json (right): https://codereview.chromium.org/12087112/diff/2001/tools/dom/docs/docs.json#newcode228 tools/dom/docs/docs.json:228: " * var request = new HttpRequest.get('http://dartlang.org', (event) ...

7 years, 10 months ago (2013-01-31 23:03:40 UTC) #4

blois

7 years, 10 months ago (2013-01-31 23:10:25 UTC) #5

lgtm

https://codereview.chromium.org/12087112/diff/2001/tools/dom/docs/docs.json
File tools/dom/docs/docs.json (right):

https://codereview.chromium.org/12087112/diff/2001/tools/dom/docs/docs.json#n...
tools/dom/docs/docs.json:228: "   *     var request = new
HttpRequest.get('http://dartlang.org', (event) => print('Request complete'));",
On 2013/01/31 23:03:40, Andrei Mouravski wrote:
> On 2013/01/31 20:45:28, blois wrote:
> > Note that this API is going away (see recent mail on dart misc).
> 
> When it goes in, the docs should also change.

It went in a half hour ago.

https://codereview.chromium.org/12087112/diff/4003/tools/dom/scripts/generato...
File tools/dom/scripts/generator.py (right):

https://codereview.chromium.org/12087112/diff/4003/tools/dom/scripts/generato...
tools/dom/scripts/generator.py:822: def GetComments(library_name,
interface_name, member_name=None):
better!

Expand Messages | Collapse Messages