Turn getters and setters that we know are not intercepted into regular getter and setter calls.

Turn getters and setters that we know are not intercepted into regular getter and setter calls.
Committed: https://code.google.com/p/dart/source/detail?r=18121

[kasperl, 2013-02-01 16:29:51]

https://codereview.chromium.org/12087101/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (right):

https://codereview.chromium.org/12087101/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:315: } else if
(selectorName == backend.jsArrayAdd.name
Maybe we could store some object in the backend that makes it easier to figure
out if a certain selector and input types match a backend helper? All the
comparisons here kind of clutter this method.

[ngeoffray, 2013-02-04 13:31:30]

Thanks Kasper. PTAL.

https://codereview.chromium.org/12087101/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (right):

https://codereview.chromium.org/12087101/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:315: } else if
(selectorName == backend.jsArrayAdd.name
On 2013/02/01 16:29:51, kasperl wrote:
> Maybe we could store some object in the backend that makes it easier to figure
> out if a certain selector and input types match a backend helper? All the
> comparisons here kind of clutter this method.

Actually, we're kind of doing a Selector.applies check, but Selector.applies
does not check the name. I have updated Selector.applies to check the names, and
updated the hot call sites of Selector.applies to Selector.appliesUnnamed.

[kasperl, 2013-02-04 13:39:03]

https://codereview.chromium.org/12087101/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (right):

https://codereview.chromium.org/12087101/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:315: // inlined
argument type checks.
but does not inlined -> but do not inline ?

https://codereview.chromium.org/12087101/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:330: return
node.inputs[1];
node.inputs[1] -> input

https://codereview.chromium.org/12087101/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/universe/universe.dart (right):

https://codereview.chromium.org/12087101/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/universe/universe.dart:467: //
[TypedSelector] are only used when compiling.
Can we assert that the names are the same in here? That would be nice.

https://codereview.chromium.org/12087101/diff/8001/tests/compiler/dart2js/int...
File tests/compiler/dart2js/interceptor_test.dart (right):

https://codereview.chromium.org/12087101/diff/8001/tests/compiler/dart2js/int...
tests/compiler/dart2js/interceptor_test.dart:48: // to be intercepted;
The comment is fairly convoluted. ; -> .

[ngeoffray, 2013-02-04 14:51:07]

PTAL

https://codereview.chromium.org/12087101/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (right):

https://codereview.chromium.org/12087101/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:315: // inlined
argument type checks.
On 2013/02/04 13:39:03, kasperl wrote:
> but does not inlined -> but do not inline ?

Done.

https://codereview.chromium.org/12087101/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:330: return
node.inputs[1];
On 2013/02/04 13:39:03, kasperl wrote:
> node.inputs[1] -> input

Done.

https://codereview.chromium.org/12087101/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/universe/universe.dart (right):

https://codereview.chromium.org/12087101/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/universe/universe.dart:467: //
[TypedSelector] are only used when compiling.
On 2013/02/04 13:39:03, kasperl wrote:
> Can we assert that the names are the same in here? That would be nice.

Done with a helper method sameNameHack, until we change the problematic
selectors (assert and constructors).

https://codereview.chromium.org/12087101/diff/8001/tests/compiler/dart2js/int...
File tests/compiler/dart2js/interceptor_test.dart (right):

https://codereview.chromium.org/12087101/diff/8001/tests/compiler/dart2js/int...
tests/compiler/dart2js/interceptor_test.dart:48: // to be intercepted;
On 2013/02/04 13:39:03, kasperl wrote:
> The comment is fairly convoluted. ; -> .

Done.

[kasperl, 2013-02-05 08:50:45]

LGTM.