Issue 12087088: Fix Socket_WriteList to use the offset for external byte arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12087088: Fix Socket_WriteList to use the offset for external byte arrays. (Closed)

Created:
7 years, 10 months ago by Mads Ager (google)

Modified:
7 years, 10 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix Socket_WriteList to use the offset for external byte arrays. R=sgjesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=17852

Patch Set 2 : Address comment. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	runtime/bin/socket.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

LGTM! https://codereview.chromium.org/12087088/diff/1/runtime/bin/socket.cc File runtime/bin/socket.cc (right): https://codereview.chromium.org/12087088/diff/1/runtime/bin/socket.cc#newcode189 runtime/bin/socket.cc:189: buffer = static_cast<void*>((static_cast<char*>(buffer) + offset)); uint8_t instead of ...

7 years, 10 months ago (2013-01-30 16:11:30 UTC) #2

Mads Ager (google)

7 years, 10 months ago (2013-01-30 16:14:25 UTC) #3

https://codereview.chromium.org/12087088/diff/1/runtime/bin/socket.cc
File runtime/bin/socket.cc (right):

https://codereview.chromium.org/12087088/diff/1/runtime/bin/socket.cc#newcode189
runtime/bin/socket.cc:189: buffer =
static_cast<void*>((static_cast<char*>(buffer) + offset));
On 2013/01/30 16:11:30, Søren Gjesse wrote:
> uint8_t instead of char*.

Done.

Expand Messages | Collapse Messages

Issue 12087088: Fix Socket_WriteList to use the offset for external byte arrays. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comment. #

Messages