Adding ease-of-use methods to HttpRequest.

Adding ease-of-use methods to HttpRequest.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=17942

[blois, 2013-01-31 00:23:27]

+Emily

[Emily Fortuna, 2013-01-31 01:04:15]

https://codereview.chromium.org/12087077/diff/7/tools/dom/templates/html/impl...
File tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate (right):

https://codereview.chromium.org/12087077/diff/7/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate:69: * succeed.
might say in the docs how this is different from the request method.

https://codereview.chromium.org/12087077/diff/7/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate:86: */
since this method replaces the functionality of the HttpRequest.get()
constructor, should we remove that constructor? If so, we should transfer the
docs from the getWithCredentials constructor here, too.

[Jennifer Messerly, 2013-01-31 04:12:17]

https://codereview.chromium.org/12087077/diff/7/tools/dom/templates/html/impl...
File tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate (right):

https://codereview.chromium.org/12087077/diff/7/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate:74: (xhr) {
maybe format this as:
(xhr) => xhr.responseText
?

https://codereview.chromium.org/12087077/diff/7/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate:80: * Creates a
URL request for the specified `url`.
[url] ?

https://codereview.chromium.org/12087077/diff/7/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate:86: */
On 2013/01/31 01:04:15, Emily Fortuna wrote:
> since this method replaces the functionality of the HttpRequest.get()
> constructor, should we remove that constructor? If so, we should transfer the
> docs from the getWithCredentials constructor here, too.

I was wondering that too. They take callbacks instead of Futures, but return a
new object, but you don't really want to use this object until the callback. A
bit strange :) I think these new static methods are better.

[blois, 2013-01-31 18:58:12]

https://codereview.chromium.org/12087077/diff/7/tools/dom/templates/html/impl...
File tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate (right):

https://codereview.chromium.org/12087077/diff/7/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate:69: * succeed.
On 2013/01/31 01:04:15, Emily Fortuna wrote:
> might say in the docs how this is different from the request method.

Done.

https://codereview.chromium.org/12087077/diff/7/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate:74: (xhr) {
On 2013/01/31 04:12:17, John Messerly wrote:
> maybe format this as:
> (xhr) => xhr.responseText
> ?

Done.

https://codereview.chromium.org/12087077/diff/7/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate:80: * Creates a
URL request for the specified `url`.
On 2013/01/31 04:12:17, John Messerly wrote:
> [url] ?

Done. Was mostly just following formatting from existing docs.

https://codereview.chromium.org/12087077/diff/7/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate:86: */
On 2013/01/31 01:04:15, Emily Fortuna wrote:
> since this method replaces the functionality of the HttpRequest.get()
> constructor, should we remove that constructor? If so, we should transfer the
> docs from the getWithCredentials constructor here, too.

The primary benefit of the factories is that you can use progress events on them
if desired. But these methods should be considered helpers and do not need to
address all scenarios.

I was a bit hesitant at first about the new APIs, so was leaving the old one in,
but now I think they should just be removed.

Added an onProgress named param to cover the progress scenario as well.

[Jennifer Messerly, 2013-01-31 18:59:29]

lgtm

[Emily Fortuna, 2013-01-31 20:32:06]

one more comment edit, and then lgtm.

https://codereview.chromium.org/12087077/diff/8001/tools/dom/templates/html/i...
File tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate (right):

https://codereview.chromium.org/12087077/diff/8001/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate:61: * Details to
keep in mind when using credentials:
can you add back in lines 45-46 explaining what sort of credentials these are?

[blois, 2013-01-31 20:51:20]

https://codereview.chromium.org/12087077/diff/8001/tools/dom/templates/html/i...
File tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate (right):

https://codereview.chromium.org/12087077/diff/8001/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate:61: * Details to
keep in mind when using credentials:
On 2013/01/31 20:32:06, Emily Fortuna wrote:
> can you add back in lines 45-46 explaining what sort of credentials these are?


Done.