Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 12087008: Handle parsing the "version" file better. (Closed)

Created:
7 years, 11 months ago by Bob Nystrom
Modified:
7 years, 10 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Handle parsing the "version" file better. Committed: https://code.google.com/p/dart/source/detail?r=17740

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -44 lines) Patch
M utils/pub/sdk.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M utils/tests/pub/command_line_config.dart View 5 chunks +11 lines, -29 lines 0 comments Download
M utils/tests/pub/pub_test.dart View 1 chunk +25 lines, -5 lines 0 comments Download
M utils/tests/pub/real_version_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/test_pub.dart View 4 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Bob Nystrom
7 years, 11 months ago (2013-01-26 01:04:44 UTC) #1
Alan Knight
7 years, 11 months ago (2013-01-26 01:36:54 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698