Issue 12086110: Use the dart:async Stream API thoroughly in Pub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12086110: Use the dart:async Stream API thoroughly in Pub. (Closed)

Created:
7 years, 10 months ago by nweiz

Modified:
7 years, 10 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use the dart:async Stream API thoroughly in Pub. This was originally submitted as r17822, and rolled back in r17867. There are no changes, but in preparation for the dart:io Stream changes we're applying this with the intent to mark Windows tests as failing. BUG=7807 Committed: https://code.google.com/p/dart/source/detail?r=17996

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+419 lines, -340 lines)			Patch
M	pkg/http/lib/src/byte_stream.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	utils/pub/command_lish.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/pub/curl_client.dart	View	3 chunks	+15 lines, -30 lines	0 comments	Download
M	utils/pub/error_group.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	utils/pub/hosted_source.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/pub/io.dart	View	13 chunks	+201 lines, -218 lines	0 comments	Download
M	utils/pub/log.dart	View	3 chunks	+12 lines, -13 lines	0 comments	Download
M	utils/pub/utils.dart	View	1 chunk	+77 lines, -0 lines	0 comments	Download
M	utils/tests/pub/curl_client_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/tests/pub/oauth2_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	utils/tests/pub/pub_uploader_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/tests/pub/test_pub.dart	View	20 chunks	+103 lines, -71 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

nweiz

I'm going to go ahead and submit this, since we talked about it in person ...

7 years, 10 months ago (2013-02-01 19:41:40 UTC) #1

Message was sent while issue was closed.

LGTM.

Expand Messages | Collapse Messages