Issue 12086048: Bugfix in test_runner: in certain cases tests did not get rerun

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12086048: Bugfix in test_runner: in certain cases tests did not get rerun (Closed)

Created:
7 years, 10 months ago by kustermann

Modified:
7 years, 10 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Bugfix in test_runner: in certain cases tests did not get rerun Committed: https://code.google.com/p/dart/source/detail?r=17824

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	tools/testing/dart/test_runner.dart	View	1	1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kustermann

Generally I don't like adding a lot of comments to code. But because our testing ...

7 years, 10 months ago (2013-01-29 19:56:44 UTC) #1

ricow1

LGTM https://codereview.chromium.org/12086048/diff/1/tools/testing/dart/test_runner.dart File tools/testing/dart/test_runner.dart (right): https://codereview.chromium.org/12086048/diff/1/tools/testing/dart/test_runner.dart#newcode1732 tools/testing/dart/test_runner.dart:1732: // TODO(ricow/kustermann): Getters should not have any I ...

7 years, 10 months ago (2013-01-29 19:58:33 UTC) #2