Issue 12086042: Fix code to not hit bug in dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12086042: Fix code to not hit bug in dart2js. (Closed)

Created:
7 years, 10 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 10 months ago

Reviewers:
karlklose, ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix code to not hit bug in dart2js. Also add library tag to test. Seems to be required. Committed: https://code.google.com/p/dart/source/detail?r=17751

Patch Set 1 #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	sdk/lib/async/stream_pipe.dart	View		1 chunk	+3 lines, -1 line	1 comment	Download
	M	tests/lib/async/stream_event_transform_test.dart	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

7 years, 10 months ago (2013-01-29 11:00:23 UTC) #3

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/12086042/diff/1/sdk/lib/async/stream_pipe.dart
File sdk/lib/async/stream_pipe.dart (right):

https://codereview.chromium.org/12086042/diff/1/sdk/lib/async/stream_pipe.dar...
sdk/lib/async/stream_pipe.dart:562: // TODO(ahe): Restore type when feature is
implemented in dart2js
I'm not sure why this TODO has my name on it?

Expand Messages | Collapse Messages