Fix up dromaeo after lib v2 merge and add Dromaeo smoketest to prevent future

Fix up dromaeo after lib v2 merge and add Dromaeo smoketest to prevent future
breakage.


BUG=

Committed: https://code.google.com/p/dart/source/detail?r=17933

[Emily Fortuna, 2013-01-30 01:15:55]

The Dromaeo tests broke with an incorrect "fix" during the lib v2 merge. This
fixes that, and I added a unittest/smoke test to verify that this runs so we
will be aware of breakage in the future. Comments on that in the code.

https://codereview.chromium.org/12086028/diff/11001/samples/third_party/droma...
File samples/third_party/dromaeo/Dromaeo.dart (left):

https://codereview.chromium.org/12086028/diff/11001/samples/third_party/droma...
samples/third_party/dromaeo/Dromaeo.dart:101: window.alert('Exception: ${e}:
${stacktrace}');
The fact that this was an alert window causes issues with selenium when it tries
to close the browser. I changed the error message just to a print message so we
can get the error information without causing as many problems for selenium.

https://codereview.chromium.org/12086028/diff/11001/tests/html/dromaeo_noop/d...
File tests/html/dromaeo_noop/dromaeo_smoke.dart.js (right):

https://codereview.chromium.org/12086028/diff/11001/tests/html/dromaeo_noop/d...
tests/html/dromaeo_noop/dromaeo_smoke.dart.js:24: /// JavaScript version of
dromaeo_smoke.dart.
This was the best solution I came up with, short of changing test.dart again,
but I am certainly open to other ideas if you have them.

[vsm, 2013-01-30 22:35:51]

https://chromiumcodereview.appspot.com/12086028/diff/11001/tests/html/dromaeo...
File tests/html/dromaeo_noop/dromaeo_smoke.dart (right):

https://chromiumcodereview.appspot.com/12086028/diff/11001/tests/html/dromaeo...
tests/html/dromaeo_noop/dromaeo_smoke.dart:1: library dromaeo;
Can you add a copyright notice on the new files?

https://chromiumcodereview.appspot.com/12086028/diff/11001/tests/html/dromaeo...
File tests/html/dromaeo_noop/dromaeo_smoke.dart.js (right):

https://chromiumcodereview.appspot.com/12086028/diff/11001/tests/html/dromaeo...
tests/html/dromaeo_noop/dromaeo_smoke.dart.js:24: /// JavaScript version of
dromaeo_smoke.dart.
It is pretty ugly to check this in, but I don't have a better idea.  One
possibility to only check the dart and only run the test on Dartium-DRT (which
should work for test runner compiled via Dart2JS as well).  But that won't work
where there is no native Dart.

On 2013/01/30 01:15:56, Emily Fortuna wrote:
> This was the best solution I came up with, short of changing test.dart again,
> but I am certainly open to other ideas if you have them.

https://chromiumcodereview.appspot.com/12086028/diff/11001/tests/html/dromaeo...
File tests/html/dromaeo_smoke_test.dart (right):

https://chromiumcodereview.appspot.com/12086028/diff/11001/tests/html/dromaeo...
tests/html/dromaeo_smoke_test.dart:24: 'client/dart.js';
This file is going to be removed.  You can use the version under pkg/browser. 
Can you make it a relative path as well instead of going over the net?

https://chromiumcodereview.appspot.com/12086028/diff/11001/tests/html/dromaeo...
tests/html/dromaeo_smoke_test.dart:49: expect(true, true);
Why?  :-)

[Emily Fortuna, 2013-01-31 00:44:58]

ptal?

Pete and I are trying to keep the status files to actually indicate failures
where there is a loss in functionality. In this case, there's not a
functionality gap; we'd just not be checking in the js to run ... I'm inclined
to keep it so as to not unnecessarily clutter our status files, but I can be
persuaded otherwise.

https://chromiumcodereview.appspot.com/12086028/diff/11001/tests/html/dromaeo...
File tests/html/dromaeo_smoke_test.dart (right):

https://chromiumcodereview.appspot.com/12086028/diff/11001/tests/html/dromaeo...
tests/html/dromaeo_smoke_test.dart:24: 'client/dart.js';
On 2013/01/30 22:35:51, vsm wrote:
> This file is going to be removed.  You can use the version under pkg/browser. 
> Can you make it a relative path as well instead of going over the net?

Done.

https://chromiumcodereview.appspot.com/12086028/diff/11001/tests/html/dromaeo...
tests/html/dromaeo_smoke_test.dart:49: expect(true, true);
On 2013/01/30 22:35:51, vsm wrote:
> Why?  :-)

Removed!

[vsm, 2013-01-31 00:54:47]

Can you add missing copyrights on new files?

Otherwise, LGTM.

[Emily Fortuna, 2013-01-31 18:04:09]

fixed up! Now with no generated code!

[vsm, 2013-01-31 18:08:46]

lgtm!