Issue 12084052: Always treat headers as individual strings in pkg/http.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12084052: Always treat headers as individual strings in pkg/http. (Closed)

Created:
7 years, 10 months ago by nweiz

Modified:
7 years, 10 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Always treat headers as individual strings in pkg/http. BUG=8049 Committed: https://code.google.com/p/dart/source/detail?r=17819

Patch Set 1 #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -2 lines)			Patch
M	pkg/http/lib/src/base_request.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/http/lib/src/io_client.dart	View	1 chunk	+3 lines, -1 line	1 comment	Download
M	pkg/http/test/client_test.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/http/test/utils.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

7 years, 10 months ago (2013-01-29 23:51:54 UTC) #2

LGTM!

https://codereview.chromium.org/12084052/diff/1/pkg/http/lib/src/io_client.dart
File pkg/http/lib/src/io_client.dart (right):

https://codereview.chromium.org/12084052/diff/1/pkg/http/lib/src/io_client.da...
pkg/http/lib/src/io_client.dart:61: headers[key] = Strings.join(values, ',');
values.join(',')

lib_v2 is like living IN THE FUTURE.

Expand Messages | Collapse Messages