Issue 12084033: Adding supported checks for touch event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12084033: Adding supported checks for touch event. (Closed)

Created:
7 years, 10 months ago by blois

Modified:
7 years, 10 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Adding supported checks for touch event. BUG=6519 Committed: https://code.google.com/p/dart/source/detail?r=17797

Patch Set 1 #

Patch Set 2 : Adding missing test file. #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -0 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	tests/html/html.status	View		5 chunks	+5 lines, -0 lines	0 comments	Download
A	tests/html/touchevent_test.dart	View	1	1 chunk	+29 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_TouchEvent.darttemplate	View		1 chunk	+20 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

7 years, 10 months ago (2013-01-29 18:19:21 UTC) #2

lgtm with comment

https://codereview.chromium.org/12084033/diff/3001/tools/dom/templates/html/i...
File tools/dom/templates/html/impl/impl_TouchEvent.darttemplate (right):

https://codereview.chromium.org/12084033/diff/3001/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_TouchEvent.darttemplate:38: // TODO: add
equivalent 'ontouchstart' check for Dartium.
TOOD(blois): ...

Expand Messages | Collapse Messages