Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 12084010: Change option --use_script_snapshot to --use-script-snapshot (easier to type). (Closed)

Created:
7 years, 11 months ago by siva
Modified:
7 years, 10 months ago
Reviewers:
ahe, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

1. Change option --use_script_snapshot to --use-script-snapshot (easier to type). 2. Use dart binary with the --generate-script-snapshot option to generate dart2js snapshot Committed: https://code.google.com/p/dart/source/detail?r=17686

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M runtime/bin/main.cc View 1 4 chunks +6 lines, -7 lines 0 comments Download
M sdk/bin/dart2js View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dart2js.bat View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartdoc View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartdoc.bat View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/create_sdk.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M utils/compiler/compiler.gyp View 1 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
7 years, 11 months ago (2013-01-26 01:45:43 UTC) #1
Ivan Posva
LGTM -ip
7 years, 11 months ago (2013-01-26 02:16:39 UTC) #2
ahe
lgtm Awesome! I didn't know this option existed, this is exactly what John is looking ...
7 years, 11 months ago (2013-01-26 09:16:45 UTC) #3
Jennifer Messerly
7 years, 10 months ago (2013-01-28 19:38:17 UTC) #4
Message was sent while issue was closed.
On 2013/01/26 09:16:45, ahe wrote:
> lgtm
> 
> Awesome! I didn't know this option existed, this is exactly what John is
looking
> for.

yeah :) thanks!!!

Powered by Google App Engine
This is Rietveld 408576698