Issue 12082126: Cleanup api for isolate state checking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12082126: Cleanup api for isolate state checking. (Closed)

Created:
7 years, 10 months ago by regis

Modified:
7 years, 10 months ago

Reviewers:
Tom Ball, siva

CC:
reviews_dartlang.org, Tom Ball

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Cleanup api for isolate state checking. This should avoid the breakage on Windows observed by reverted r17962. Committed: https://code.google.com/p/dart/source/detail?r=18013

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -69 lines)			Patch
M	runtime/vm/dart_api_impl.h	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1	12 chunks	+41 lines, -54 lines	0 comments	Download
M	runtime/vm/debugger_api_impl.cc	View	1	3 chunks	+9 lines, -9 lines	0 comments	Download
M	runtime/vm/snapshot.cc	View	1	3 chunks	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/snapshot_test.cc	View	1	3 chunks	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/12082126/diff/1/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/12082126/diff/1/runtime/vm/dart_api_impl.cc#newcode162 runtime/vm/dart_api_impl.cc:162: if (obj.IsError()) { Shouldn't this always be an ...

7 years, 10 months ago (2013-02-01 22:56:26 UTC) #3

regis

7 years, 10 months ago (2013-02-01 23:43:16 UTC) #4

Thanks!

https://codereview.chromium.org/12082126/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/12082126/diff/1/runtime/vm/dart_api_impl.cc#n...
runtime/vm/dart_api_impl.cc:162: if (obj.IsError()) {
On 2013/02/01 22:56:26, siva wrote:
> Shouldn't this always be an Error, in what cases can it not be an error.
> 
> Maybe we just assert it is an Error here.

Done.

Expand Messages | Collapse Messages

Issue 12082126: Cleanup api for isolate state checking. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages