Issue 12082051: Perform substitution on the unaliased type of a typedef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12082051: Perform substitution on the unaliased type of a typedef. (Closed)

Created:
7 years, 10 months ago by Johnni Winther

Modified:
7 years, 10 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Perform substitution on the unaliased type of a typedef. Committed: https://code.google.com/p/dart/source/detail?r=17905

Patch Set 3 : Updated cf. comment #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -2 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/dart_types.dart	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
	M	tests/compiler/dart2js/type_substitution_test.dart	View	1 2	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

I still need to run full tests and change status files.

7 years, 10 months ago (2013-01-29 15:33:02 UTC) #1

karlklose

LGTM. https://codereview.chromium.org/12082051/diff/1/tests/compiler/dart2js/type_substitution_test.dart File tests/compiler/dart2js/type_substitution_test.dart (right): https://codereview.chromium.org/12082051/diff/1/tests/compiler/dart2js/type_substitution_test.dart#newcode247 tests/compiler/dart2js/type_substitution_test.dart:247: print('$Typedef2_int_String.unalias=$unalias1'); No need to print the types, Expect.equals ...

7 years, 10 months ago (2013-01-30 09:05:09 UTC) #2

Johnni Winther

7 years, 10 months ago (2013-01-31 12:40:07 UTC) #3

https://codereview.chromium.org/12082051/diff/1/tests/compiler/dart2js/type_s...
File tests/compiler/dart2js/type_substitution_test.dart (right):

https://codereview.chromium.org/12082051/diff/1/tests/compiler/dart2js/type_s...
tests/compiler/dart2js/type_substitution_test.dart:247:
print('$Typedef2_int_String.unalias=$unalias1');
On 2013/01/30 09:05:09, karlklose wrote:
> No need to print the types, Expect.equals will print them when they are not
> equal.

Done.

Expand Messages | Collapse Messages

Issue 12082051: Perform substitution on the unaliased type of a typedef. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Updated cf. comment #

Messages