Add optional and named parameters to FunctionType.

Add optional and named parameters to FunctionType.

Intentionally omit equals/hashCode implementation for a later CL which updates Types.isSubtype.

Committed: https://code.google.com/p/dart/source/detail?r=17760

[karlklose, 2013-01-29 13:13:29]

https://codereview.chromium.org/12082045/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart
(right):

https://codereview.chromium.org/12082045/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart:391:
compiler.types.voidType, const Link<DartType>(),
Could you either put each argument on its own line or fill the lines?

https://codereview.chromium.org/12082045/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/12082045/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:868: return
new FunctionType(element,
You can share this code with l. 897 by storing the optinal and named parameters
into local link builders.

https://codereview.chromium.org/12082045/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/typechecker.dart (right):

https://codereview.chromium.org/12082045/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/typechecker.dart:429: this.isMalformed
= returnType != null &&
It is annoying that we cannot use field initializers for this list. Could we
make isMalformed a getter, or would that be too expensive?

https://codereview.chromium.org/12082045/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/typechecker.dart:440:
Link<SourceString> namedParameter = namedParameters;
Perhaps call this 'names' (plural works better with links, I think).

https://codereview.chromium.org/12082045/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/typechecker.dart:441: Link<DartType>
namedParameterType = namedParameterTypes;
And this 'types'.

https://codereview.chromium.org/12082045/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/typechecker.dart:443: if (name ==
namedParameter.head) {
How does this work? name is a string.

[karlklose, 2013-01-29 13:15:12]

LGTM after you remove the unused method and fix the comment.

[Johnni Winther, 2013-01-29 13:53:58]

https://codereview.chromium.org/12082045/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart
(right):

https://codereview.chromium.org/12082045/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart:391:
compiler.types.voidType, const Link<DartType>(),
On 2013/01/29 13:13:29, karlklose wrote:
> Could you either put each argument on its own line or fill the lines?

Done.

https://codereview.chromium.org/12082045/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/12082045/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:868: return
new FunctionType(element,
On 2013/01/29 13:13:29, karlklose wrote:
> You can share this code with l. 897 by storing the optinal and named
parameters
> into local link builders.

Done.

https://codereview.chromium.org/12082045/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/typechecker.dart (right):

https://codereview.chromium.org/12082045/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/typechecker.dart:429: this.isMalformed
= returnType != null &&
On 2013/01/29 13:13:29, karlklose wrote:
> It is annoying that we cannot use field initializers for this list. Could we
> make isMalformed a getter, or would that be too expensive?

Done.

https://codereview.chromium.org/12082045/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/typechecker.dart:439: DartType
getNamedParameterType(String name) {
Method removed.