Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1208183002: Don't normalize the CR test either. (Closed)

Created:
5 years, 6 months ago by rmacnak
Modified:
5 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M .gitattributes View 1 chunk +1 line, -0 lines 3 comments Download

Messages

Total messages: 7 (2 generated)
rmacnak
5 years, 6 months ago (2015-06-25 18:31:26 UTC) #2
herhut
Thanks! LGTM https://codereview.chromium.org/1208183002/diff/1/.gitattributes File .gitattributes (right): https://codereview.chromium.org/1208183002/diff/1/.gitattributes#newcode13 .gitattributes:13: # Windows files that should not be ...
5 years, 6 months ago (2015-06-26 07:22:15 UTC) #3
herhut
Committed patchset #1 (id:1) manually as dc02e2064a912a54a0be1fe0dab6fd477d7ef37d (presubmit successful).
5 years, 6 months ago (2015-06-26 11:13:07 UTC) #4
Lasse Reichstein Nielsen
https://codereview.chromium.org/1208183002/diff/1/.gitattributes File .gitattributes (right): https://codereview.chromium.org/1208183002/diff/1/.gitattributes#newcode15 .gitattributes:15: tests/lib/mirrors/method_mirror_source_line_ending_crlf.dart -text I think the _ending_lf.dart file should also ...
5 years, 6 months ago (2015-06-26 13:02:41 UTC) #6
rmacnak
5 years, 6 months ago (2015-06-26 16:56:21 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/1208183002/diff/1/.gitattributes
File .gitattributes (right):

https://codereview.chromium.org/1208183002/diff/1/.gitattributes#newcode15
.gitattributes:15: tests/lib/mirrors/method_mirror_source_line_ending_crlf.dart
-text
On 2015/06/26 13:02:40, Lasse Reichstein Nielsen wrote:
> I think the _ending_lf.dart file should also not be converted on Windows.

Added in 0d70fd8d9f574adedeeb3faadfd13c1a16ed9cba

Powered by Google App Engine
This is Rietveld 408576698