Issue 12079116: Fix a crash in dart2js where references to this in inlined initializers id not know what instructio…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12079116: Fix a crash in dart2js where references to this in inlined initializers id not know what instructio… (Closed)

Created:
7 years, 10 months ago by ngeoffray

Modified:
7 years, 10 months ago

Reviewers:
Johnni Winther, floitsch

CC:
reviews_dartlang.org, Mads Ager (google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix a crash in dart2js where references to this in inlined initializers id not know what instruction to use. Committed: https://code.google.com/p/dart/source/detail?r=17982

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -1 line)			Patch
	M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View		1 chunk	+7 lines, -1 line	0 comments	Download
	A	tests/language/type_variable_initializer_test.dart	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/12079116/diff/1/tests/language/type_variable_initializer_test.dart File tests/language/type_variable_initializer_test.dart (right): https://codereview.chromium.org/12079116/diff/1/tests/language/type_variable_initializer_test.dart#newcode10 tests/language/type_variable_initializer_test.dart:10: A() : map = new Map<T, T>(); Add ...

7 years, 10 months ago (2013-02-01 13:58:19 UTC) #2

ngeoffray

7 years, 10 months ago (2013-02-01 14:10:59 UTC) #3

Thanks Johnni.

https://codereview.chromium.org/12079116/diff/1/tests/language/type_variable_...
File tests/language/type_variable_initializer_test.dart (right):

https://codereview.chromium.org/12079116/diff/1/tests/language/type_variable_...
tests/language/type_variable_initializer_test.dart:10: A() : map = new Map<T,
T>();
On 2013/02/01 13:58:20, Johnni Winther wrote:
> Add a comment explaining why this requires access to A#this.

Done.

Expand Messages | Collapse Messages

Issue 12079116: Fix a crash in dart2js where references to this in inlined initializers id not know what instructio… (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages